This repository was archived by the owner on Jul 30, 2024. It is now read-only.
[fs] WriteStream wrongly imports ReadStream #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exoego
force-pushed
the
fix-jsimport
branch
2 times, most recently
from
ce19122 to
7a78579
Compare
exoego
commented
May 29, 2020
| assert(new WriteStream("package.json") !== null) | ||
| assert(new WriteStream(Buffer.from("package.json")) !== null) | ||
| assert(new WriteStream(new URL(s"file:///${dirname}/package.json")) !== null) | ||
| assert(new WriteStream("NO_SUCH_FILE").writableLength === 0) |
There was a problem hiding this comment.
Note) Opening with correct WriteStream empty its file, so changed the file to be opened.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other
@JSImportmatched its class names.